Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Oct 1, 2016, 18:55 UTC
- Message-ID
- <a3a74863-f7c4-4c9b-619d-33fbe0c33860@gmail.com>
- In-Reply-To
- <xmqqy42fwotm.fsf@gitster.mtv.corp.google.com>
W dniu 26.09.2016 o 01:18, Junio C Hamano pisze:
Show 12 quoted lines
> Vasco Almeida <vascomalmeida@sapo.pt> writes:
>
>> @@ -1403,7 +1412,7 @@ Message-Id: $message_id
>> if ($quiet) {
>> printf (($dry_run ? "Dry-" : "")."Sent %s\n", $subject);
>> } else {
>> - print (($dry_run ? "Dry-" : "")."OK. Log says:\n");
>> + print (($dry_run ? "Dry-" : ""). __("OK. Log says:\n"));
>
> I am not sure about this change. We either say Dry-Sent/Dry-OK
> (under --dry-run) or "Sent/OK"; don't you want "dry-" part also
> translated?Actually, we would probably want to unfold it, that is use __("Dry-OK. Log says:\n") and __("OK. Log says:\n"), etc.
-- Jakub Narębski