Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 25, 2016, 23:14 UTC
- Message-ID
- <xmqq37kny3kh.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1472646690-9699-9-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 15 quoted lines
> - $_ = ask("What to do with this address? ([q]uit|[d]rop|[e]dit): ",
> + # TRANSLATORS: Make sure to include [q] [d] [e] in your
> + # translation. The program will only accept English input
> + # at this point.
> + $_ = ask(__("What to do with this address? ([q]uit|[d]rop|[e]dit): "),
> valid_re => qr/^(?:quit|q|drop|d|edit|e)/i,
> default => 'q');
> ...
> - $_ = ask("Send this email? ([y]es|[n]o|[q]uit|[a]ll): ",
> + # TRANSLATORS: Make sure to include [y] [n] [q] [a] in your
> + # translation. The program will only accept English input
> + # at this point.
> + $_ = ask(__("Send this email? ([y]es|[n]o|[q]uit|[a]ll): "),
> valid_re => qr/^(?:yes|y|no|n|quit|q|all|a)/i,
> default => $ask_default);The same comment as the one for the prompt in "add -i" applies here. If something should not be translated, perhaps we are better off pushing it outside __(), no?