Re: [PATCH v2 03/11] i18n: add--interactive: mark strings with interpolation for translation

> W dniu 31.08.2016 o 14:31, Vasco Almeida pisze:
> > Use of sprintf following die or error_msg is necessary for
> > placeholder
> > substitution take place.
> 
> No, it is not.  Though I don't think that we have in out Git::I18N
> the support for Perl i18n placeholder substitution.

> From gettext manual:
> https://www.gnu.org/software/gettext/manual/gettext.html#perl_002dfor
> mat
> 
>   15.3.16 Perl Format Strings
> 
>   There are two kinds format strings in Perl: those acceptable to the
> Perl
>   built-in function printf, labelled as ‘perl-format’, and those
> acceptable
>   to the libintl-perl function __x, labelled as ‘perl-brace-format’.
> 
>   Perl printf format strings are described in the sprintf section of
>   ‘man perlfunc’.
> 
>   Perl brace format strings are described in the
> Locale::TextDomain(3pm)
>   manual page of the CPAN package libintl-perl. In brief, Perl format
> uses
>   placeholders put between braces (‘{’ and ‘}’). The placeholder must
> have
>   the syntax of simple identifiers.
>  
> Git doesn't use Locale::TextDomain, from what I understand, to
> provide
> fallback in no-gettext case.  Also, Locale::TextDomain is not in
> core.

> > diff --git a/git-add--interactive.perl b/git-add--interactive.perl
> > index e11a33d..4e1e857 100755
> > --- a/git-add--interactive.perl
> > +++ b/git-add--interactive.perl
> > @@ -612,12 +612,12 @@ sub list_and_choose {
> >                       else {
> >                               $bottom = $top = find_unique($choice, @stuff);
> >                               if (!defined $bottom) {
> > -                                     error_msg "Huh ($choice)?\n";
> > +                                     error_msg sprintf(__("Huh (%s)?\n"), $choice);
> 
> So this would be, self explained without need of comment
> for translators:
> 
>   +                                     error_msg __x ("Huh ({choice})?\n"), choice => $choice);
> 
> 
> >                                       next TOPLOOP;
> >                               }
> 
> Though this is probably more work that you wanted to do.
> The __x might be defined like this (borrowing from Locale::TextDomain),
> which needs to be put into perl/Git/I18N.pm
> 
>   sub __ ($);
>   sub __expand ($%);
> 
>   # With interpolation.
>   sub __x ($@)
>   {
>         my ($msgid, %vars) = @_;
> 
>         return __expand (__($msgid), %vars);
>   }
>   
>   sub __expand ($%)
>   {
>         my ($translation, %args) = @_;
>     
>         my $re = join '|', map { quotemeta $_ } keys %args;
>         $translation =~ s/\{($re)\}/defined $args{$1} ? $args{$1} : "{$1}"/ge;
> 
>         return $translation;
>   }