Re: [PATCH v2 02/11] i18n: add--interactive: mark simple here documents for translation
- From
Vasco Almeida <vascomalmeida@sapo.pt>
- Date
- Sep 29, 2016, 14:31 UTC
- Message-ID
- <1475159493.2435.7.camel@sapo.pt>
- In-Reply-To
- <xmqqmvivy4i9.fsf@gitster.mtv.corp.google.com>
A Dom, 25-09-2016 às 15:54 -0700, Junio C Hamano escreveu:
Show 25 quoted lines
> > sub status_cmd {
> > @@ -1573,14 +1573,14 @@ sub quit_cmd {
> > }
> >
> > sub help_cmd {
> > - print colored $help_color, <<\EOF ;
> > -status - show paths with changes
> > + print colored $help_color, __(
> > +"status - show paths with changes
> > update - add working tree state to the staged set of
> changes
> > revert - revert staged set of changes back to the HEAD
> version
> > patch - pick hunks and update selectively
> > diff - view diff between HEAD and index
> > -add untracked - add contents of untracked files to the staged set
> of changes
> > -EOF
> > +add untracked - add contents of untracked files to the staged set
> of changes"),
> > +"\n";
> > }
>
> Do we need TRANSLATORS: comment to all of the above not to touch the
> command words that are explained and translate only the explanation?Yes, it is better to have that comment.
On the other hand, would it make sense to translate these commands? If so, we would mark for translation the commands name of @cmd in main_loop().
sub main_loop {
- my @cmd = ([ 'status', \&status_cmd, ],
- [ 'update', \&update_cmd, ],
- [ 'revert', \&revert_cmd, ],
- [ 'add untracked', \&add_untracked_cmd, ],
- [ 'patch', \&patch_update_cmd, ],
- [ 'diff', \&diff_cmd, ],
- [ 'quit', \&quit_cmd, ],
- [ 'help', \&help_cmd, ],
+ my @cmd = ([ __('status'), \&status_cmd, ],
+ [ __('update'), \&update_cmd, ],
+ [ __('revert'), \&revert_cmd, ],
+ [ __('add untracked'), \&add_untracked_cmd, ],
+ [ __('patch'), \&patch_update_cmd, ],
+ [ __('diff'), \&diff_cmd, ],
+ [ __('quit'), \&quit_cmd, ],
+ [ __('help'), \&help_cmd, ],