Re: [PATCH v2 09/10] pretty: implement 'summary' format

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2019, 02:44 UTC
Message-ID: <xmqqy2wj89dv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191114003757.GR4348@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 7 quoted lines

> Yeah, it's as simple as adding:
>
>   { "reference",  CMIT_FMT_USERFORMAT,    1,      0, 0, "%C(auto)%h (%s, %as)" }
>
> Works like a charm, I've been using it for a few years now:
>
>   https://github.com/szeder/git/commit/3604d0c28e7e2da5415986468994ef71a972e4ed

The word "reference" does sound more to the point for the feature than "summary", and it is nice to see that the required change is essentially a single liner ;-)

> but never seriously considered for submission, because I didn't want
> to argue about removing the double-quotes around the subject, and

I personally do not care whether the title is naked or inside a dq-pair, as that part is purely for human consumption. Being for human consumption, I guess we can argue that the shorter the better, so we may want to standardise the recommendation we give in our tutorials and such.

> couldn't be bothered to check the corner cases (e.g. what if a user
> sets a pretty format alias with the same name in the configuration?).

It would be already possible to collide with built-in names, like "short", with or without your addition, wouldn't it? Then that is not an issue you would need to be worried about, right?

Thanks.