Re: [PATCH v3 09/10] pretty: implement 'reference' format

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2019, 06:07 UTC
Message-ID: <xmqqbltd7juo.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <470a2b0f4fd450af1d9c9d27ec0f0c91ea59117f.1573764280.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> +* 'reference'
> +
> +	  <abbrev hash> (<title line>, <short author date>)

s/title line/title/ as you definitely do *not* want a line with a title on it (and nothing else) in this context.

Show 5 quoted lines

> +This format is useful for referring to other commits when writing a new
> +commit message. It uses the following canned user format:
> +`%C(auto)%h (%s, %as)`. This means it will not respect options that
> +change the output format such as `--date` `--no-abbrev-commit`, and
> +`--walk-reflogs`.

Ignoring of the '--date' may want to be eventually fixed, but for an initial cut, using %as in the canned format is a good approach for expediency.

I thought that %h can be told to give arbitrary long hash with --abbrev=<n>, up to n==40 (or the number of bytes the hash of your choice has), so I am not sure if `--no-abbrev-commit` is worth mentioning. I do not think I understand what you wanted to do by using `--walk-reflogs` with the format at all, either.

Thanks.