Re: [PATCH v3 09/10] pretty: implement 'reference' format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 18, 2019, 01:44 UTC
- Message-ID
- <xmqq5zji3qm0.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqqr228619w.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> SZEDER Gábor <szeder.dev@gmail.com> writes: > >> On Fri, Nov 15, 2019 at 03:07:59PM +0900, Junio C Hamano wrote: >>> Denton Liu <liu.denton@gmail.com> writes: >>> >>> > +* 'reference' >>> > + >>> > + <abbrev hash> (<title line>, <short author date>) >>> >>> s/title line/title/ as you definitely do *not* want a line with a >>> title on it (and nothing else) in this context. >> >> Well, we just followed suit of the descriptions of other pretty >> formats, and they all say "<title line>".
Sorry I failed to respond to this point. I think it is OK to leave it <title line> in this series, then. Updating them need to be done for all at once together with other formats.
Thanks.