Re: [PATCH v4 11/11] squash! pretty: implement 'reference' format

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 19, 2019, 03:10 UTC
Message-ID: <xmqq7e3wzhlx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <580aa7c88c0b18d752f9aa951166a2c82dbcd031.1574122784.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

Show 7 quoted lines

> Note that we explicitly special-case `--pretty=reference` to use
> `DATE_SHORT` by default in get_commit_format(). Although this isn't a
> very elegant way of doing this, it has to be done this way because we
> implement `--pretty=reference` as a user-format and, after this
> function, it is treated as a normal user-format. This is the only part
> of the pretty codepath where we can actually tell that we are dealing
> with a "special" format so we have to do it here.

I was hoping that by extending cmt_fmt_map horizontally, we can cause the date mode (and other things in the future) to optionally default to the format specific value, without hardcoding the string constant in the code. After all, that (i.e. not having to hardcode per-format specific constants) is the original point of using table(s) to describe the customization.