Re: [PATCH 7/8] pretty: implement 'summary' format

From: Denton Liu <liu.denton@gmail.com>
Date: Nov 4, 2019, 20:35 UTC
Message-ID: <20191104203558.GA8004@generichostname>
In-Reply-To: <CAPig+cRVgf3q6-mHeMgOThCrhseTGtYt+S6x1ikUSEKGbUTz4g@mail.gmail.com>

Hi Eric,

On Mon, Nov 04, 2019 at 03:16:56PM -0500, Eric Sunshine wrote:

Show 12 quoted lines

> On Mon, Nov 4, 2019 at 3:04 PM Denton Liu <liu.denton@gmail.com> wrote:
> > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> > @@ -63,6 +63,15 @@ This is designed to be as compact as possible.
> > +* 'summary'
> > +
> > +         <abbrev hash> ("<title line>", <short author date>)
> > ++
> > +This format is useful for referring to other commits when writing a new
> > +commit message. Although by default, '<abbrev sha1>' is used, this can
> 
> Why does this talk about "sha1" when patch 1/8 removed references to
> SHA-1 in favor of generic "hashes"?

Good catch. 1/8 modified pretty-formats.txt but this message references the content in SubmittingPatches.

In a future reroll, I'll submit a similar patch as 1/8 but targeting SubmittingPatches instead.

Thanks,

Denton

> 
> > +be overridden with '--no-abbrev'. In addition, '<short author date>' can
> > +be overridden by with '--date='.