Re: [PATCH 0/2] am: support --always option to am empty commits

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2021, 06:47 UTC
Message-ID: <xmqqy25tj2fi.fsf@gitster.g>
In-Reply-To: <6da5e984-1dcf-4c55-976c-49ffb8d128bf@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 7 quoted lines

> Am 12.11.21 um 05:58 schrieb Aleen via GitGitGadget:
>> Since that git has supported the --always option for the git-format-patch
>> command to create a patch with empty commit message, git-am should support
>> applying and committing with empty patches.
>
> The symmetry is compelling, but "always" is quite generic.  I can see
> e.g. someone expecting "git am --always" to imply --keep-non-patch.

What symmetry?

> git commit and cherry-pick have --allow-empty, which is (a bit) more
> specific.  That seems to me a better option name to copy for a commit-
> creating command like git am.

That one I can believe, even though I do not necessarily think it is a good idea to add such an option.