Re: [PATCH v6 2/3] am: support --empty option to handle empty patches
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Nov 19, 2021, 12:10 UTC
- Message-ID
- <211119.861r3c4a4g.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <877e2b84-347d-8687-d3dc-6c7ce508ac1d@gmail.com>
On Fri, Nov 19 2021, Bagas Sanjaya wrote:
Show 8 quoted lines
> On 18/11/21 17.50, Aleen via GitGitGadget wrote: >> +test_expect_success 'still output error with --empty when meeting empty files' ' >> + test_must_fail git am --empty=drop empty.patch 2>actual && >> + echo Patch format detection failed. >expected && >> + test_cmp expected actual >> +' > > Why isn't the echo string quoted?
There's no need to quote the arguments given to echo in cases like these.
It's not the same, i.e. it'll get N arguments on argv and not on, but it makes it easier to spot things that do need quoting, rather than over-quoting everything.