Re: [PATCH v8 2/2] am: support --empty=<option> to handle empty patches

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2021, 07:06 UTC
Message-ID: <xmqqbl2ck6u1.fsf@gitster.g>
In-Reply-To: <3ff18e16a7a24fdd8c57b40960e0d6b95c2490e6.1637563611.git.gitgitgadget@gmail.com>

"Aleen via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> From: Aleen <aleen42@vip.qq.com>
>
> Since that the command 'git-format-patch' can include patches of
> commits that emit no changes, the 'git-am' command should also
> support an option, named as '--empty', to specify how to handle
> those empty patches. In this commit, we have implemented three
> valid options ('die', 'drop' and 'keep').
>
> Signed-off-by: Aleen 徐沛文 <aleen42@vip.qq.com>

Perhaps this line should imitate what Hans Krentel did in https://lore.kernel.org/git/pull.1143.git.git.1637347813367.gitgitgadget@gmail.com/, i.e. real name first, and then (nickname) in parentheses.

Also, the in-body "From:" line should match the sign off.

I corrected what has been queued in 'seen' manually when I applied the previous round.

> +--empty=(die|drop|keep)::

This is the only change relative to what is queued (we had "--empty-commit", which is remnant from an earlier iteration), and it makes the documentation consistent with what the code does.

Good.