Re: [PATCH 0/2] am: support --always option to am empty commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 12, 2021, 16:08 UTC
- Message-ID
- <xmqqmtm9tkzz.fsf@gitster.g>
- In-Reply-To
- <ca9baf51-28ca-048d-ded6-f4834874f7c3@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 6 quoted lines
>>> The symmetry is compelling, but "always" is quite generic. I can see >>> e.g. someone expecting "git am --always" to imply --keep-non-patch. >> >> What symmetry? > > To have the same option in both producer and consumer.
Well, "--always" that stands for "--always-show-header" seeps through to the command line parser from revision.c layer but that is by accident, and is not even documented. We may want to file it as a bug and fix it later.
As you mentioned, allow-empty-commit does sound like a much better name.