Re: [PATCH] gpg-interface: reflect stderr to stderr

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2016, 18:20 UTC
Message-ID: <xmqqwpimgso6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160907083947.b7q7ebe62xsr6447@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Wed, Sep 07, 2016 at 10:27:34AM +0200, Michael J Gruber wrote:
>
>> Now, I can't reproduce C on Linux[*], so there is more involved. It
>> could be that my patch just exposes a problem in our start_command()
>> etc.: run-command.c contains a lot of ifdefing, so possibly quite
>> different code is run on different platforms.
>
> Maybe, though my blind guess is that it is simply that on Linux we can
> open /dev/tty directly, and console-IO on Windows is a bit more
> complicated.

True.

Even though this patch is fixing only one of the two issues, I am tempted to say that we should queue it for now, as it does so without breaking a bigger gain made by the original, i.e. we learn the status of verification in a way the authors of GPG wants us to, while somebody figuires out what the best way is to show the prompt to the console on Windows.