Re: [PATCH] gpg-interface: reflect stderr to stderr

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 6, 2016, 16:43 UTC
Message-ID: <alpine.DEB.2.20.1609061843120.129229@virtualbox>
In-Reply-To: <alpine.DEB.2.20.1609061839370.129229@virtualbox>

Hi Michael,

okay, final mail on this issue today:

On Tue, 6 Sep 2016, Johannes Schindelin wrote:

Show 8 quoted lines

> Your original issue seemed to be that the gpg command could succeed, but
> still no signature be seen. There *must* be a way to test whether the
> called program added a signature, simply by testing whether *any*
> characters were written.
> 
> And if characters were written that were not actually a GPG signature,
> maybe the enterprisey user who configured the gpg command to be her magic
> script actually meant something else than a GPG signature to be added?

I actually just saw that this is *precisely* what the code does already:

        if (ret || signature->len == bottom)
                return error(_("gpg failed to sign the data"));

Why is this not good enough?

Ciao, Dscho