git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gpg-interface: reflect stderr to stderr

From
Jeff King <peff@peff.net>
Date
Sep 8, 2016, 20:03 UTC
Message-ID
<20160908200305.okeeh35xmrvcveyg@sigill.intra.peff.net>
In-Reply-To
<xmqqwpimgso6.fsf@gitster.mtv.corp.google.com>
On Thu, Sep 08, 2016 at 11:20:09AM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Wed, Sep 07, 2016 at 10:27:34AM +0200, Michael J Gruber wrote:
> >
> >> Now, I can't reproduce C on Linux[*], so there is more involved. It
> >> could be that my patch just exposes a problem in our start_command()
> >> etc.: run-command.c contains a lot of ifdefing, so possibly quite
> >> different code is run on different platforms.
> >
> > Maybe, though my blind guess is that it is simply that on Linux we can
> > open /dev/tty directly, and console-IO on Windows is a bit more
> > complicated.
> 
> True.
> 
> Even though this patch is fixing only one of the two issues, I am
> tempted to say that we should queue it for now, as it does so
> without breaking a bigger gain made by the original, i.e. we learn
> the status of verification in a way the authors of GPG wants us to,
> while somebody figuires out what the best way is to show the prompt
> to the console on Windows.

That's OK by me, but I don't know if we can put off the "best way to show the prompt" fix. It seems like a pretty serious regression for people on Windows.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 16 in “Unbreak interactive GPG prompt upon signing”
  1. Unbreak interactive GPG prompt upon signingJohannes Schindelin, Sep 6, 2016
  2. Michael J GruberSep 6, 2016
  3. gpg-interface: reflect stderr to stderrMichael J Gruber, Sep 6, 2016
  4. Johannes SchindelinSep 6, 2016
  5. Johannes SchindelinSep 6, 2016
  6. Johannes SchindelinSep 6, 2016
  7. Michael J GruberSep 7, 2016
  8. Jeff KingSep 7, 2016
  9. Michael J GruberSep 7, 2016
  10. Junio C HamanoSep 8, 2016
  11. Jeff KingSep 8, 2016
  12. Junio C HamanoSep 8, 2016
  13. Michael J GruberSep 12, 2016
  14. Johannes SchindelinOct 2, 2018
  15. Johannes SchindelinSep 9, 2016
  16. Johannes SchindelinSep 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.