Re: [PATCH] gpg-interface: reflect stderr to stderr

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 6, 2016, 16:30 UTC
Message-ID: <alpine.DEB.2.20.1609061827290.129229@virtualbox>
In-Reply-To: <18a7e2984121d988137c135ec560fee56506981b.1473167263.git.git@drmicha.warpmail.net>

Hi Michael,

On Tue, 6 Sep 2016, Michael J Gruber wrote:

Show 11 quoted lines

> efee955 ("gpg-interface: check gpg signature creation status",
> 2016-06-17) used stderr to capture gpg's status output, which is the
> only reliable way for status checks. As a side effect, stderr was not
> shown to the user any more.
> 
> In case of a gpg error, reflect the whole captured buffer to stderr.
> 
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> A full blown approach would use --status-fd=4 or such rather than hijacking stderr.
> This would require an extension of pipe_command() etc. to handle yet another fd.

As I indicated in my patch, this is not enough on Windows. In fact, my first version of a patch tried to do exactly what you presented here, and all it did was make the error message a bit more verbose:

-- snip -- error: gpg failed to sign the data: [GNUPG:] USERID_HINT <key> Johannes Schindelin <johannes.schindelin@gmx.de> [GNUPG:] NEED_PASSPHRASE <key> <key2> 1 0 gpg: cannot open tty `no tty': No such file or directory

error: unable to sign the tag -- snap --

This is not a fix for the issue reported on the Git for Windows, but only half a fix.

Ciao, Dscho