Re: [PATCH v2 2/3] prune: fix pruning with multiple worktrees and split index

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2018, 19:12 UTC
Message-ID: <xmqqwp0xe8ul.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20180103221849.GC2641@hank>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 19 quoted lines

> [sorry for the late reply.  I was on Christmas holidays until today
> and am still catching up on the mailing list.  It will probably take
> me untill the weekend to send a re-roll]
>
> On 12/18, Brandon Williams wrote:
>> On 12/17, Thomas Gummerer wrote:
>> > be489d02d2 ("revision.c: --indexed-objects add objects from all
>> > worktrees", 2017-08-23) made sure that pruning takes objects from all
>> > worktrees into account.
>> > 
>> > It did that by reading the index of every worktree and adding the
>> > necessary index objects to the set of pending objects.  The index is
>> > read by read_index_from.  As mentioned in the previous commit,
>> > read_index_from depends on the CWD for the location of the split index,
>> 
>> As I mentioned before this doesn't actually depend on the CWD but
>> rather the per-worktree gitdir.
>
> Right, will fix.

Thanks.