Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jan 24, 2018, 09:11 UTC
- Message-ID
- <CACsJy8AVL4HzPxRjwT9qSc8g_5FwAVgpbEPQ5TfDuxr9C91wqA@mail.gmail.com>
- In-Reply-To
- <20180122182717.21539-1-szeder.dev@gmail.com>
On Tue, Jan 23, 2018 at 1:27 AM, SZEDER Gábor <szeder.dev@gmail.com> wrote:
Show 28 quoted lines
> > On Thu, Jan 18, 2018 at 1:47 PM, Duy Nguyen <pclouds@gmail.com> wrote: >> On Thu, Jan 18, 2018 at 6:36 PM, SZEDER Gábor <szeder.dev@gmail.com> wrote: >>> This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux >>> build job fail on Travis CI. Unfortunately, all it can tell us about >>> the failure is this: >>> >>> Test Summary Report >>> ------------------- >>> t1700-split-index.sh (Wstat: 256 Tests: 23 >>> Failed: 1) >>> Failed test: 23 >>> Non-zero exit status: 1 >>> Files=809, Tests=18491, 401 wallclock secs ( 7.22 usr 1.60 sys + 263.16 >>> cusr 49.58 csys = 321.56 CPU) >>> Result: FAIL >>> >>> because it can't access the test's verbose log due to lack of >>> permissions. >>> >>> >>> https://travis-ci.org/git/git/jobs/329681826#L2074 >> >> I may need help getting that log (or even better the trash directory >> of t1700). > > Well, shower thoughts gave me an idea, see the included PoC patch below. > I can't really decide whether it's too clever or too ugly :)
I can't comment on the patch. But there is one thing I think I should mention. As someone new to Travis, I didn't know that I could set up my own Travis jobs and get the logs myself. Maybe you should point that out when you point people to travis test failures (which I appreciate).
-- Duy