Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jan 19, 2018, 00:30 UTC
- Message-ID
- <CACsJy8AgwKY8xXYp3w39EfoGgoWjN3oNiBju4fV2du4PWaWsHg@mail.gmail.com>
- In-Reply-To
- <CAM0VKjmAjw0a2JzsY1BaAwZcCp8ge+jQaGN6L_nKTLugHeWyvQ@mail.gmail.com>
On Fri, Jan 19, 2018 at 5:32 AM, SZEDER Gábor <szeder.dev@gmail.com> wrote:
Show 17 quoted lines
> On Thu, Jan 18, 2018 at 10:37 PM, Jeff King <peff@peff.net> wrote: >> On Thu, Jan 18, 2018 at 10:00:14PM +0700, Duy Nguyen wrote: >> >>> The test suite was run as root, no wonder why my removing write access >>> has no effect. I got the test to pass with this, but then it fails >>> with >>> >>> Can't write .prove (Permission denied) at /usr/share/perl/5.22/App/Prove.pm line 542. >>> >>> Some more chown'ing or chmod'ing is required.... > > This is the fallout of running the tests as root in the past. With your > patch 'prove' is run as a non-root user, but the prove state is loaded > from Travis CI's cache, where it has been written as root the last time > around, so now we don't have permissions to (over)write it. > > I have patches in the works to address this as well.
Great. I'll leave it to you then. I will update the test with SANITY (and a small fix in the test name) and think more about the "-i" Jeff mentioned.
-- Duy