Re: [PATCH 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 13, 2017, 17:38 UTC
- Message-ID
- <xmqq4louy1d9.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <09E575DE-ED7A-40FA-9A47-0ABB61452C28@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 13 quoted lines
> I think your solution points into the right direction. > Right now we have the following test matrix: > > 1. Linux - clang > 2. Linux - gcc > 3. Mac - clang > 4. Mac - gcc > 5. Linux - gcc - GET_TEXT_POISION > 6. Linux - gcc - 32bit > 7. Windows > > AFAIK your solution would run the split index test for > 1, 2, 3, and 4. I think that is too much.
Not that it matters too much, but I meant to add it to 1. and 6. when I said "only one of 64-bit build plus 32-bit one".
Show 7 quoted lines
> 1 runs the fastest and I would like to keep it that way > to get a quick "general" result. I think only 2 should be > extended in the way you are suggesting. We could run > the tests with different env variables there. What else > do we have besides GIT_TEST_SPLIT_INDEX? > > Would that work for everyone?
I am OK to make 2. use split-index (which unfortunately would mean we lose tests without split-index under gcc), or add 2.5 that is a copy of 2. plus split-index.