Re: [PATCH v2 4/4] cat-file: add mailmap support
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 7, 2022, 21:55 UTC
- Message-ID
- <xmqqwncoy4de.fsf@gitster.g>
- In-Reply-To
- <20220707161554.6900-5-siddharthasthana31@gmail.com>
Siddharth Asthana <siddharthasthana31@gmail.com> writes:
> +char *replace_idents_using_mailmap(char *object_buf, size_t *size)
Does this function need to be extern? If nobody other than callers in cat-file would call it, perhaps it should be file-scope static.
> +{
> + struct strbuf sb = STRBUF_INIT;
> + strbuf_attach(&sb, object_buf, *size, *size + 1);
> + const char *headers[] = { "author ", "committer ", "tagger ", NULL };This is decl-after-statement.
> + apply_mailmap_to_header(&sb, headers, &mailmap); > + *size = sb.len; > + return strbuf_detach(&sb, NULL); > +}