Re: [PATCH v4 1/4] revision: improve commit_rewrite_person()

From: Christian Couder <christian.couder@gmail.com>
Date: Jul 13, 2022, 12:18 UTC
Message-ID: <CAP8UFD363FPO=eOnzb_8T54eVn2c8SGAvV+27rB=gwzs6o-cNA@mail.gmail.com>
In-Reply-To: <220713.86mtdd4xdd.gmgdl@evledraar.gmail.com>

On Wed, Jul 13, 2022 at 3:25 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 12 quoted lines

>
>
> On Tue, Jul 12 2022, Siddharth Asthana wrote:
>
> > -static int commit_rewrite_person(struct strbuf *buf, const char *what, struct string_list *mailmap)
> > +/*
> > + * Returns the difference between the new and old length of the ident line.
> > + */
> > +static ssize_t rewrite_ident_line(const char* person, struct strbuf *buf, struct string_list *mailmap)
>
> All tests pass with this as size_t, instead of size_t. Let's use that
> here instead?

Do you mean you would like to use size_t instead of ssize_t for the type of the value returned by the function?

I think it can return a negative value if the new length of the ident line is shorter than the old one though.