Re: [PATCH 3/3] cat-file: add mailmap support

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 30, 2022, 21:33 UTC
Message-ID: <xmqqletddegb.fsf@gitster.g>
In-Reply-To: <CAP8UFD2tYzoKSr7HnQ+LbCE+YWoNqo3qPQrbr7ZWAMnDt+ajCg@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> "Even if git cat-file is a plumbing command, it has gained more and
> more high level features like its `--batch-command` mode."

What batch-command and batch do does not sound like "high level" at all. It is just "instead of invoking separate process to ask about each individual object, a single process answers the same low level requests".

Independent of what this "The output from 'cat-file commit' is tweaked" feature, I wonder if we want a command that can be used as a filter. Just like "git name-rev --stdin" reads a stream of text, finds commit-looking references in it, and annotates them, the command (e.g. "git mailmap") would find ident-looking strings and replaces with the mapped results, or something.

Show 6 quoted lines

>> > At this time, this patch only adds a command line
>> > option, but perhaps a `cat-file.mailmap` config option could be added as
>> > well in the same way as for `git log`.
>>
>> As cat-file is a plumbing command that is used by scripts we should not
>> add a config option for this as it would potentially break those scripts.

Absolutely.