Re: [PATCH 1/1] imap-send: include strbuf.h

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2023, 15:49 UTC
Message-ID: <xmqqwn17q7ou.fsf@gitster.g>
In-Reply-To: <20230517070632.71884-1-list@eworm.de>

Christian Hesse <list@eworm.de> writes:

Show 8 quoted lines

> From: Christian Hesse <mail@eworm.de>
>
> We use xstrfmt() here, so let's include the header file.
>
> Signed-off-by: Christian Hesse <mail@eworm.de>
> ---
>  imap-send.c | 1 +
>  1 file changed, 1 insertion(+)

Puzzled. For me Git 2.41-rc0 builds as-is without this change just fine, it seems. I know there are many header file shuffling patches flying around, and I have seen some of them, but is this a fix for one of these patches?

Thanks.

Show 13 quoted lines

>
> diff --git a/imap-send.c b/imap-send.c
> index a62424e90a..7f5426177a 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -29,6 +29,7 @@
>  #include "run-command.h"
>  #include "parse-options.h"
>  #include "setup.h"
> +#include "strbuf.h"
>  #include "wrapper.h"
>  #if defined(NO_OPENSSL) && !defined(HAVE_OPENSSL_CSPRNG)
>  typedef void *SSL;