Re: [PATCH 1/1] imap-send: include strbuf.h

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2023, 17:01 UTC
Message-ID: <xmqq8rdmrixc.fsf@gitster.g>
In-Reply-To: <xmqqcz2yrjbe.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

>>         if ! gcc -I $(pwd) -E $f | grep -q 'struct strbuf {'
> ...
> What does the above prove, more than what your regular compilation
> that does not fail, tells us?

It is actually worse than that, isn't it? This does not even use the definition in the config.mak.uname, so it is not even matching your build environment.

I am uncomfortable to use this as an explanation of what due diligence we did to convince ourselves that this fix should cover all similar issues. Perhaps I am grossly misunderstanding what your investigation did?

Thanks.