Re: [PATCH 1/1] imap-send: include strbuf.h

From: Taylor Blau <me@ttaylorr.com>
Date: May 17, 2023, 16:02 UTC
Message-ID: <ZGT6fEZFumAsZnxu@nand.local>
In-Reply-To: <xmqqwn17q7ou.fsf@gitster.g>

On Wed, May 17, 2023 at 08:49:37AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Christian Hesse <list@eworm.de> writes:
>
> > From: Christian Hesse <mail@eworm.de>
> >
> > We use xstrfmt() here, so let's include the header file.
> >
> > Signed-off-by: Christian Hesse <mail@eworm.de>
> > ---
> >  imap-send.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Puzzled.  For me Git 2.41-rc0 builds as-is without this change just
> fine, it seems.

It will fail to build for ancient versions of curl (pre-7.34.0, which was released in 2013), or if you build with `NO_CURL=1`.

> I know there are many header file shuffling patches flying around, and
> I have seen some of them, but is this a fix for one of these patches?

Similar to [1], this bisects to ba3d1c73da (treewide: remove unnecessary cache.h includes, 2023-02-24).

Thanks, Taylor

[1]: https://lore.kernel.org/git/ZGP2tw0USsj9oecZ@nand.local/