Re: [PATCH 1/1] imap-send: include strbuf.h

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2023, 15:56 UTC
Message-ID: <xmqqbkihvdiw.fsf@gitster.g>
In-Reply-To: <20230517221850.1117204b@leda.eworm.net>

Christian Hesse <list@eworm.de> writes:

Show 14 quoted lines

> Christian Hesse <list@eworm.de> on Wed, 2023/05/17 22:12:
>> > OK, so the fix seems to make sense, but the justification for the
>> > change needs to be rewritten, I think.
>> > 
>> >     We make liberal use of the strbuf API functions and types, but
>> >     the inclusion of <strbuf.h> comes indirectly by including
>> >     <http.h>, which does not happen if you build with NO_CURL.
>> > 
>> > or something like that?  
>> 
>> Fine with me!
>> Do you want me to re-send the patch or do you modify this on the fly?
>
> Found it in next branch already. Thanks a lot!

We made moderate amount of these kind of header shuffling this cycle, and it is inevitable to encounter a gotcha like this when building with anything less than the most common configurations.

Thanks for reporting and fixing; very much appreciated.