Re: [PATCH 1/1] imap-send: include strbuf.h

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2023, 18:12 UTC
Message-ID: <xmqqttwaq133.fsf@gitster.g>
In-Reply-To: <016701d988ea$4e4ffcd0$eaeff670$@nexbridge.com>

<rsbecker@nexbridge.com> writes:

Show 12 quoted lines

>>Oof, yes, you are right:
>>
>>    diff -u \
>>      <(gcc -I . -E imap-send.c) \
>>      <(gcc -DNO_CURL=1 -I . -E imap-send.c)
>>
>>How *should* we test this?
>
> I hope not by using gcc, which is not currently a
> dependency. Using the C preprocessor directly might help in a more
> general sense, but you probably will need a knob for some
> compilers to work.

I am not going to suggest trying all permutations of CPP macros to make sure we cover all the #ifdef'ed sections, but -E to show CPP output is pretty common feature not limited to "gcc", so if we were to do that, we'd very likely use the usual $(CC) Makefile macro to invoke such a test.