git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 10, 2017, 19:42 UTC
Message-ID
<xmqqvargyl39.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170309181837.GF153031@google.com>
Brandon Williams <bmwill@google.com> writes:
Show 7 quoted lines
> On 03/09, Valery Tolstov wrote:
>> Remove code fragment from module_clone that duplicates functionality
>> of connect_work_tree_and_git_dir in dir.c
>> 
>> Signed-off-by: Valery Tolstov <me@vtolstov.org>
>
> Looks good.
I'll queue with your Reviewed-by: added.

If sb/checkout-recurse-submodules is going to be rerolled, I'd appreciate if it includes this patch inserted at an appropriate place in the series, instead of me having to remember re-applying this patch every time it happens.

Thanks.
Previous: Brandon WilliamsNext: Stefan Beller
Message 12 of 24 in “submodule--helper.c: remove duplicate code”
  1. submodule--helper.c: remove duplicate codeme@vtolstov.org, Mar 8, 2017
  2. Stefan BellerMar 8, 2017
  3. Valery TolstovMar 8, 2017
  4. Stefan BellerMar 8, 2017
  5. 0/2 Remove duplicate code from module_clone()Valery Tolstov, Mar 9, 2017
  6. 1/2 connect_work_tree_and_git_dir: safely create leading directoriesValery Tolstov, Mar 9, 2017
  7. 2/2 submodule--helper.c: remove duplicate codeValery Tolstov, Mar 9, 2017
  8. Brandon WilliamsMar 9, 2017
  9. 0/2 Remove duplicate code from module_clone()Valery Tolstov, Mar 9, 2017
  10. 2/2 submodule--helper.c: remove duplicate codeValery Tolstov, Mar 9, 2017
  11. Brandon WilliamsMar 9, 2017
  12. Junio C HamanoMar 10, 2017
  13. Stefan BellerMar 10, 2017
  14. Junio C HamanoMar 10, 2017
  15. Stefan BellerMar 10, 2017
  16. Valery TolstovMar 9, 2017
  17. 1/2 connect_work_tree_and_git_dir: safely create leading directoriesValery Tolstov, Mar 9, 2017
  18. Brandon WilliamsMar 9, 2017
  19. Valery TolstovMar 9, 2017
  20. Brandon WilliamsMar 9, 2017
  21. Valery TolstovMar 8, 2017
  22. Stefan BellerMar 8, 2017
  23. Junio C HamanoMar 8, 2017
  24. Stefan BellerMar 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.