Re: [PATCH] submodule--helper.c: remove duplicate code

From: Stefan Beller <sbeller@google.com>
Date: Mar 8, 2017, 23:15 UTC
Message-ID: <CAGZ79ka7PNKq5JWLPujvVHJWf6eEUadaJXd5AmKEvKT_y1ghOA@mail.gmail.com>
In-Reply-To: <20170308230512.30572-1-me@vtolstov.org>

On Wed, Mar 8, 2017 at 3:05 PM, Valery Tolstov <me@vtolstov.org> wrote:

Show 7 quoted lines

>> Then the next step (as outlined by Documentation/SubmittingPatches)
>> is to figure out how to best present this to the mailing list; I think the best
>> way is to send out a patch series consisting of both of these 2 patches,
>> the "connect_work_tree_and_git_dir: safely create leading directories,"
>> first and then your deduplication patch.
>
> Is there a handy way to forward your patch in new patch series?

No there is not. :(

Here is what I would do:
* Take the patch and "git am" it (you probably did that for testing already.)
* use "git rebase --interactive" to get the order right,
* use "git format-patch HEAD^^ --cover-letter" to create the series.
    (This will take care of e.g. rewriting the patch to be numbered correctly)
* use "git send-email 00* --to=list --cc=Junio ..." etc to send it out
as a new series.

Alternatively you can take the patch file you sent and that patch and manually edit their numbering and send them out. (PATCH 1/2 and PATCH 2/2)

> Also,
> should I start new thread for new patch series?

As you like. As far as I understand, it is very easy for Junio to take a whole (sub-)thread of patches and apply that and make a branch with multiple commits out of it as he has tooling for that.

>
> Regards,
>   Valery Tolstov

Thanks, Stefan