Re: [PATCH] submodule--helper.c: remove duplicate code

From: Stefan Beller <sbeller@google.com>
Date: Mar 8, 2017, 20:25 UTC
Message-ID: <CAGZ79kbnpUtrKdjQdQ-r6rRuVvnawooLFk1bO8jOSgxNkx2Dbg@mail.gmail.com>
In-Reply-To: <20170308195916.7349-1-me@vtolstov.org>

On Wed, Mar 8, 2017 at 11:59 AM, Valery Tolstov <me@vtolstov.org> wrote:

Show 9 quoted lines

>> Maybe we need to have 2293f77a081
>> (connect_work_tree_and_git_dir: safely create leading directories,
>> part of origin/sb/checkout-recurse-submodules, also found at
>> https://public-inbox.org/git/20170306205919.9713-8-sbeller@google.com/ )
>> first before we can apply this patch.
>
> Thank you for your detailed responses. Yes, we difenitely need this
> patch first. All tests passed when I applied it.
>

Thanks for testing!

Then the next step (as outlined by Documentation/SubmittingPatches) is to figure out how to best present this to the mailing list; I think the best way is to send out a patch series consisting of both of these 2 patches, the "connect_work_tree_and_git_dir: safely create leading directories," first and then your deduplication patch.

When applied in that order, then git passes the test suite at all commits (which is very nice when using e.g. git-bisect on git).

Thanks, Stefan