Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 10, 2017, 19:49 UTC
- Message-ID
- <CAGZ79kbhG9XhRccqA555Zp-FENJ5Q6Nd+LnNTZno1J_=cGQctQ@mail.gmail.com>
- In-Reply-To
- <xmqqvargyl39.fsf@gitster.mtv.corp.google.com>
On Fri, Mar 10, 2017 at 11:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Brandon Williams <bmwill@google.com> writes: > >> On 03/09, Valery Tolstov wrote: >>> Remove code fragment from module_clone that duplicates functionality >>> of connect_work_tree_and_git_dir in dir.c >>> >>> Signed-off-by: Valery Tolstov <me@vtolstov.org> >> >> Looks good. > > I'll queue with your Reviewed-by: added. > > If sb/checkout-recurse-submodules is going to be rerolled, I'd > appreciate if it includes this patch inserted at an appropriate > place in the series, instead of me having to remember re-applying > this patch every time it happens.
Instead of mixing these two series, can you just take Valerys series as is, and sb/checkout-recurse-submodules builds on top of that when rerolled?
Thanks, Stefan
> > Thanks.