Re: [PATCH] check-ref-format: require a repository for --branch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 18, 2017, 07:45 UTC
- Message-ID
- <xmqqvallco9v.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170818062021.gqhsose5kepth55h@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> I _do_ think it's a misfeature to put it in check-ref-format. It should
> be part of rev-parse. Which admittedly is a kitchen sink, but this kind
> of resolving is one of the main things it should be doing. And in fact
> you can already do:
>
> git rev-parse --symbolic-full-name @{-1}
>
> But I stopped short of suggesting we remove the feature entirely. It
> would obviously require a deprecation period.Yeah, I realize that "nonsense" was a bit too strong. I do agree that it was a misfeature to place in "check" ref-format, though.
Thanks.