Re: [PATCH] check-ref-format: require a repository for --branch

From: Jeff King <peff@peff.net>
Date: Oct 16, 2017, 22:45 UTC
Message-ID: <20171016224512.6fhtce5anmff577b@sigill.intra.peff.net>
In-Reply-To: <xmqq1sm3s751.fsf@gitster.mtv.corp.google.com>

On Mon, Oct 16, 2017 at 07:45:46PM +0900, Junio C Hamano wrote:

Show 8 quoted lines

> > So I think the right endgame in the longer term is:
> > ...
> 
> Here is to illustrate what I mean in a patch form.  It resurrects
> the gentle setup, and uses a purely textual format check when we are
> outside the repository, while bypassing the @{magic} interpolation
> codepath that requires us to be in a repository.  When we are in a
> repository, we operate the same way as before.

I like the state this puts us in, but there's one catch: we're completely changing the meaning of "check-ref-format --branch", aren't we?

It is going from "this is how you resolve @{-1}" to "this is how you check the validity of a potential branch name". Do we need to pick a different name, and/or have a deprecation period?

-Peff