Re: [PATCH v4 20/21] ci: speed up Windows phase
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 23, 2019, 23:35 UTC
- Message-ID
- <xmqqva2f3pwd.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <6520f4603c78d38f5168164218dc108833a5583d.1548254412.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 24 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > As Unix shell scripting comes at a hefty price on Windows, we have to > see where we can save some time to run the test suite. > > Let's skip the chain linting and the bin-wrappers/ redirection on > Windows; this seems to shave of anywhere between 10-30% from the overall > runtime. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > ci/lib.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ci/lib.sh b/ci/lib.sh > index 91cf1402bf..e1d5222ceb 100755 > --- a/ci/lib.sh > +++ b/ci/lib.sh > @@ -43,6 +43,8 @@ then > BREW_INSTALL_PACKAGES= > export GIT_PROVE_OPTS="--timer --jobs 10 --state=failed,slow,save" > export GIT_TEST_OPTS="--verbose-log -x --write-junit-xml" > + test windows_nt != "$CI_OS_NAME" || > + GIT_TEST_OPTS="--no-chain-lint --no-bin-wrappers $GIT_TEST_OPTS"
A clever and clean workaround. Looks good.