Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 14, 2018, 19:07 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1809141407180.73@tvgsbejvaqbjf.bet>
- In-Reply-To
- <179314eb-774a-bc98-4a41-f79ec78c8466@gmail.com>
Hi Sebastian,
On Wed, 5 Sep 2018, Sebastian Schuberth wrote:
Show 11 quoted lines
> On 9/3/2018 11:10 PM, Johannes Schindelin via GitGitGadget wrote: > > > +if test -n "$TRAVIS_COMMIT" > > +then > > + # We are running within Travis CI > > Personally, I'd find a check like > > if test "$TRAVIS" = "true" > > more speaking (also see [1]).
Good call.
Will fix, Dscho
Show 7 quoted lines
> > [1] https://docs.travis-ci.com/user/environment-variables/ > > -- > Sebastian Schuberth > >