Re: [PATCH v2 09/13] git-p4: use `test_atexit` to kill the daemon

From: Luke Diamand <luke@diamand.org>
Date: Oct 15, 2018, 11:00 UTC
Message-ID: <CAE5ih79cNkVVQOkaeJifSqkcp=HGmRb3a=jJC=g08iV8dYRyXg@mail.gmail.com>
In-Reply-To: <3e2193a73de0b68d5a38f1792642c828f4aed1db.1539598316.git.gitgitgadget@gmail.com>

On Mon, 15 Oct 2018 at 11:12, Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 7 quoted lines

>
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This should be more reliable than the current method, and prepares the
> test suite for a consistent way to clean up before re-running the tests
> with different options.
>

I'm finding that it's leaving p4d processes lying around.

e.g.

$ ./t9820-git-p4-editor-handling.sh <passes> $ ./t9820-git-p4-editor-handling.sh <fails>

And also

$ ./t9800-git-p4-basic.sh <starts running tests, but I get bored easily> Ctrl-C

$ ./t9800-git-p4-basic.sh <fails>

$ ps | grep p4d 21392 pts/1 00:00:00 p4d <<<<<

Luke