Re: [PATCH v4 06/21] test-date: add a subcommand to measure times in shell scripts
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2019, 23:14 UTC
- Message-ID
- <xmqqsgxdelqy.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqqo98754gy.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> I think the goal to have our own stopwatch so that we do not have to > worry about differences among system-provided ones makes sense. > > The only thing that may become an issue is how widely available > getnanotime() is. As "test-date" itself is built on any platform an > end-user/developer runs our tests, which is wider set of platforms > than what we run Travis and other CIs on, unconditionally relying on > its availability might pose an issue.
Sorry for a false alarm, as the codebase in many places like fsmonitor, progress, trace and wt-status have been assuming getnanotime() to be available for quite some time, and this is just another user of the same function.