Re: [PATCH v7 08/10] config: teach git_config_source to remember its scope
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2020, 18:14 UTC
- Message-ID
- <xmqqv9oez4wa.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <6c59c5cace7e1f8fc16737c2c9dcf2016397caa1.1581294660.git.gitgitgadget@gmail.com>
"Matthew Rogers via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 16 quoted lines
> From: Matthew Rogers <mattr94@gmail.com> > > There are many situations where the scope of a config command is known > beforehand, such as passing of '--local', '--file', etc. to an > invocation of git config. However, this information is lost when moving > from builtin/config.c to /config.c. This historically hasn't been a big > deal, but to prepare for the upcoming --show-scope option we teach > git_config_source to keep track of the source and the config machinery > to use that information to set current_parsing_scope appropriately. > > Signed-off-by: Matthew Rogers <mattr94@gmail.com> > --- > builtin/config.c | 16 +++++++++++++--- > config.c | 3 +++ > config.h | 20 ++++++++++---------- > 3 files changed, 26 insertions(+), 13 deletions(-)
This is split from the last step in the previous round, and the splitting makes sense.
Thanks.