Re: [PATCH v3 4/4] config: add '--show-scope' to print the scope of a config value

From: Matt Rogers <mattr94@gmail.com>
Date: Jan 18, 2020, 15:42 UTC
Message-ID: <CAOjrSZvFphMaJ7Yaj4pq1qp+UJixgULN7qSf8v_xKKRePgXceg@mail.gmail.com>
In-Reply-To: <xmqqsgkddbjz.fsf@gitster-ct.c.googlers.com>

Show 5 quoted lines

> The HERE-DOC is over-indented.  All the body lines should align with
> cat and EOF.  The same comment applies to many "<<-" added by this
> patch---mimick the "<<-" that appear in earlier part of the same
> file.
>

I was mimicking the style of the --show-origin tests, and didn't realize this was a style violation. This is done in a few tests, so I'll add a patch that just goes through the file and fixes that for the existing tests as well.

Show 13 quoted lines

> I wonder if we want to revamp the tests for --show-origin that wants
> to make sure a funny filename is quoted properly.  For that purpose,
> CUSTOM_CONFIG_FILE is given a funny pathname, and it would have been
> OK to use that only for a single "do we quote properly?" test, but
> instead we use that same funnily-named file as the source in many
> places where we do not *care* how --show-origin quotes the pathname
> at all, and end up having to skip with !MINGW.
>
> It's a bad tradition that started at 45bf3297 ("t1300: fix the new
> --show-origin tests on Windows", 2016-03-23), I guess, and is not a
> new problem introduced by this patch, but it should stop so that we
> can have a better test coverage everywhere.
>

Agreed.

> Other than that, I think that the new feature added by this series
> is a sensible one.  Thanks for working on it.
>

You're welcome!  And thank you for the careful review.

-- 
Matthew Rogers