Re: [PATCH v7 04/10] config: make scope_name non-static and rename it

From: Emily Shaffer <emilyshaffer@google.com>
Date: Feb 11, 2020, 01:58 UTC
Message-ID: <20200211015811.GE190927@google.com>
In-Reply-To: <CAOjrSZvm-3qVw4880MeDVk59ToCwp9vMC1zFp-SYaDsFd3Y=8g@mail.gmail.com>

On Mon, Feb 10, 2020 at 07:30:22PM -0500, Matt Rogers wrote:

Show 13 quoted lines

> >
> > How are you reviewing the patches in your own series before sending
> > them out?  This round is better than the previous rounds where we
> > didn't have a matching change to the tests so "make test" may not
> > have passed in the middle of the series, though...
> >
> 
> I went through each patch individually using rebase -i and built/tested it.
> Although just to save time I only did t1300 and t1308 since I believe those were
> the only ones that should be affected.  I can write a script that
> would run the whole
> test suite overnight for me and make sure the series shakes out okay,
> if you'd like.

Not sure whether you intend to do this or not, but to maybe save you some scripting, I do this like so:

  git rebase -x \
    "make -j16 && (cd t && prove -j16 -v --shuffle t[0-9]*.sh)" master

If the tests fail, the rebase is paused, which can be understandably disappointing if you walk away from it overnight only to have it fail after 10 minutes, though. :)

 - Emily