Re: [PATCH v2 1/4] config: fix typo in variable name
- From
Jeff King <peff@peff.net>
- Date
- Jan 10, 2020, 11:55 UTC
- Message-ID
- <20200110115505.GA979160@coredump.intra.peff.net>
- In-Reply-To
- <b40480f03a5643761bd06d4b9c495a99b98a1ac8.1578565001.git.gitgitgadget@gmail.com>
On Thu, Jan 09, 2020 at 10:16:38AM +0000, Matthew Rogers via GitGitGadget wrote:
> - OPT_BOOL('z', "null", &end_null, N_("terminate values with NUL byte")),
> + OPT_BOOL('z', "null", &end_nul, N_("terminate values with NUL byte")),The user-facing option is still spelled "null". Obviously we can't just change that, but if we are trying to prefer "nul", should we offer both?
I think we actually _do_ allow "--nul" because of parse-option's willingness to accept a partial name. But if we wanted to advertise one over the other in "-h", then we'd have to set up the alias ourselves.
Interestingly, "xargs" (and GNU grep) spells it as "--null", so perhaps that's an argument to keep it as-is. Likewise if we accept that "null termination" is a correct name, I suppose.
-Peff