Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2020, 04:17 UTC
Message-ID: <xmqqtv3tpzto.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqk14qqj7n.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> So the diff was taken from <20200123175645.GF6837@szeder.dev>; with
> Szeder's SoB (and possibly wordsmithing the log message) let's tie
> this loose end.

Now we are running some tests under py3, we seem to be failing the tip of 'pu'

    https://travis-ci.org/git/git/jobs/650160479

that is getting a SyntaxError.

    if message.find(separatorLine) <> -1:

There are other breakages whose causes are already identified in the recent list messages, e.g.

    https://travis-ci.org/git/git/jobs/650160481

is due to a non-portable sed invocation in the bugreport topic,

    https://travis-ci.org/git/git/jobs/650160486

is also due to the same topic, and

    https://travis-ci.org/git/git/jobs/650160483

is due to the forbidden "for (type var = init; ...)" construct in new C code.