git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)

From
Denton Liu <liu.denton@gmail.com>
Date
Feb 14, 2020, 05:15 UTC
Message-ID
<20200214051505.GA16130@generichostname>
In-Reply-To
<xmqqtv3tpzto.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Thu, Feb 13, 2020 at 08:17:39PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> Now we are running some tests under py3, we seem to be failing the
> tip of 'pu'
> 
>     https://travis-ci.org/git/git/jobs/650160479
> 
> that is getting a SyntaxError.
> 
>     if message.find(separatorLine) <> -1:

This change comes from 'git-p4: restructure code in submit' in 'bk/p4-pre-edit-changelist' which introduced the use of the `<>` operator. In Python 2, this is valid but in Python 3, it was removed.

We can simply replace the `<>` with `!=` which is the new way of writing "not equals".

Previous: Junio C HamanoNext: Ben Keene
Message 7 of 16 in “What's cooking in git.git (Feb 2020, #03; Wed, 12)”
  1. Junio C HamanoFeb 12, 2020
  2. bw/remote-rename-update-config, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)Johannes Schindelin, Feb 13, 2020
  3. yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)Johannes Schindelin, Feb 13, 2020
  4. Junio C HamanoFeb 13, 2020
  5. Junio C HamanoFeb 13, 2020
  6. Junio C HamanoFeb 14, 2020
  7. Denton LiuFeb 14, 2020
  8. Ben KeeneFeb 14, 2020
  9. Junio C HamanoFeb 14, 2020
  10. Junio C HamanoFeb 14, 2020
  11. Ben KeeneFeb 14, 2020
  12. Junio C HamanoFeb 14, 2020
  13. SZEDER GáborMar 10, 2020
  14. Junio C HamanoMar 10, 2020
  15. Elijah NewrenFeb 16, 2020
  16. Pratyush YadavFeb 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.