Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2020, 17:01 UTC
Message-ID: <xmqq8sl5p0hf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <7fc48fbe-4cf4-7a0a-22f6-eac9692abc9b@gmail.com>

Ben Keene <seraphire@gmail.com> writes:

Show 8 quoted lines

> On 2/14/2020 12:15 AM, Denton Liu wrote:
>> This change comes from 'git-p4: restructure code in submit' in
>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>
>> We can simply replace the `<>` with `!=` which is the new way of
>> writing "not equals".
> Absolutely. I'm committing the change now.

Thanks.

I didn't mean that the use of <> was the only bug in 'pu' wrt Python
3.  I see you sent a new round out, but has it been tested under
Python 3 already?  Just checking to set my expectation right.