Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)

From: Ben Keene <seraphire@gmail.com>
Date: Feb 14, 2020, 17:05 UTC
Message-ID: <9d1d3f2e-fef2-bcba-8065-c33ff6c5c0c3@gmail.com>
In-Reply-To: <xmqq8sl5p0hf.fsf@gitster-ct.c.googlers.com>

On 2/14/2020 12:01 PM, Junio C Hamano wrote:

Show 15 quoted lines

> Ben Keene <seraphire@gmail.com> writes:
>
>> On 2/14/2020 12:15 AM, Denton Liu wrote:
>>> This change comes from 'git-p4: restructure code in submit' in
>>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>>
>>> We can simply replace the `<>` with `!=` which is the new way of
>>> writing "not equals".
>> Absolutely. I'm committing the change now.
> Thanks.
>
> I didn't mean that the use of <> was the only bug in 'pu' wrt Python
> 3.  I see you sent a new round out, but has it been tested under
> Python 3 already?  Just checking to set my expectation right.

I have not been able to test my changes under Py3. Unfortunately I don't have the bandwidth at present to incorporate Yang's code into this code for testing. I've been having to work with Python 2 at present and using my changes locally. I have tried to not use Python2 only code, but cross compatible code but I'm not sure what other errors might be present.

I'm fine if this needs to stay pending until Yang is complete and I can then retest with the new code.