git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 14, 2020, 18:10 UTC
Message-ID
<xmqqimk9nior.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<9d1d3f2e-fef2-bcba-8065-c33ff6c5c0c3@gmail.com>
Ben Keene <seraphire@gmail.com> writes:
Show 25 quoted lines
> On 2/14/2020 12:01 PM, Junio C Hamano wrote:
>> Ben Keene <seraphire@gmail.com> writes:
>>
>>> On 2/14/2020 12:15 AM, Denton Liu wrote:
>>>> This change comes from 'git-p4: restructure code in submit' in
>>>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>>>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>>>
>>>> We can simply replace the `<>` with `!=` which is the new way of
>>>> writing "not equals".
>>> Absolutely. I'm committing the change now.
>> Thanks.
>>
>> I didn't mean that the use of <> was the only bug in 'pu' wrt Python
>> 3.  I see you sent a new round out, but has it been tested under
>> Python 3 already?  Just checking to set my expectation right.
> I have not been able to test my changes under Py3. Unfortunately I
> don't have the bandwidth at present to incorporate Yang's code into
> this code for testing. I've been having to work with Python 2 at
> present and using my changes locally.  I have tried to not use Python2
> only code, but cross compatible code but I'm not sure what other
> errors might be present.
>
> I'm fine if this needs to stay pending until Yang is complete and
> I can then retest with the new code.

Nah, I'd have replaced and rebuilt 'pu' anyway. I just wanted to know how much I should be surprised if I saw any other Python3 issues when Travis sees the updated 'pu' later today.

Previous: Ben KeeneNext: SZEDER Gábor
Message 12 of 16 in “What's cooking in git.git (Feb 2020, #03; Wed, 12)”
  1. Junio C HamanoFeb 12, 2020
  2. bw/remote-rename-update-config, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)Johannes Schindelin, Feb 13, 2020
  3. yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)Johannes Schindelin, Feb 13, 2020
  4. Junio C HamanoFeb 13, 2020
  5. Junio C HamanoFeb 13, 2020
  6. Junio C HamanoFeb 14, 2020
  7. Denton LiuFeb 14, 2020
  8. Ben KeeneFeb 14, 2020
  9. Junio C HamanoFeb 14, 2020
  10. Junio C HamanoFeb 14, 2020
  11. Ben KeeneFeb 14, 2020
  12. Junio C HamanoFeb 14, 2020
  13. SZEDER GáborMar 10, 2020
  14. Junio C HamanoMar 10, 2020
  15. Elijah NewrenFeb 16, 2020
  16. Pratyush YadavFeb 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.