git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 22, 2026, 20:56 UTC
Message-ID
<xmqqtsmde9o9.fsf@gitster.g>
In-Reply-To
<20260917132540.GA101514@peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Thu, Sep 17, 2026 at 05:03:50PM +0300, Vsevolod Myalitsin wrote:
>
>> Junio C Hamano writes:
>> > So to conclude the topic, we would only need this?
>> 
>> Yes, I think this is indeed where we were heading.
>
> Likewise, and the patch looks good to me from a quick read.
>
>> However, during the discussion I really liked the idea of passing a
>> pointer to the "advice_setting" to "vadvise()" instead of passing its
>> individual fields. It seems like a cleaner interface, even though it
>> is not directly related to this fix.
>> 
>> Would it make sense to submit that change as a separate patch?
>
> I think so. I probably would not have looked into it as a cleanup on its
> own, but since we already spent time thinking about it, let's not waste
> those brain cycles.

So I should mark jc/advice-config-set-global for 'next' and Vsevolod can look into cleaning up the API as an independent effort?

Previous: Jeff KingNext: Vsevolod Myalitsin
Message 28 of 32 in “advice: use global config for default branch name”
  1. advice: use global config for default branch nameVsevolod Myalitsin, Aug 29, 2027
  2. Jeff KingSep 9, 2026
  3. Junio C HamanoSep 9, 2026
  4. Vsevolod MyalitsinSep 9, 2026
  5. Jeff KingSep 9, 2026
  6. Vsevolod MyalitsinSep 10, 2026
  7. Junio C HamanoSep 9, 2026
  8. Vsevolod MyalitsinSep 9, 2026
  9. Junio C HamanoSep 9, 2026
  10. 0/3 defaultBranchName advice is uselessVsevolod Myalitsin, Sep 10, 2026
  11. 2/3 advice: introduce advice scoping mechanismVsevolod Myalitsin, Sep 10, 2026
  12. Junio C HamanoSep 10, 2026
  13. Jeff KingSep 10, 2026
  14. Vsevolod MyalitsinSep 10, 2026
  15. Jeff KingSep 10, 2026
  16. Junio C HamanoSep 10, 2026
  17. Jeff KingSep 10, 2026
  18. Junio C HamanoSep 10, 2026
  19. Jeff KingSep 10, 2026
  20. Junio C HamanoSep 10, 2026
  21. Vsevolod MyalitsinSep 12, 2026
  22. Junio C HamanoSep 13, 2026
  23. Jeff KingSep 14, 2026
  24. Junio C HamanoSep 14, 2026
  25. Junio C HamanoSep 14, 2026
  26. Vsevolod MyalitsinSep 17, 2026
  27. Jeff KingSep 17, 2026
  28. Junio C HamanoOct 22, 2026
  29. 3/3 advice: use global config for default branch nameVsevolod Myalitsin, Sep 10, 2026
  30. 1/3 advice: pass the entire advice_setting to vadvise()Vsevolod Myalitsin, Sep 10, 2026
  31. SZEDER GáborSep 10, 2026
  32. David TimberOct 24, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.