Re: [PATCH v4 1/3] advice: pass the entire advice_setting to vadvise()

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Sep 10, 2026, 17:43 UTC
Message-ID: <aqLsMDcvqgRZ8MVO@szeder.dev>
In-Reply-To: <20260910085353.109373-2-ub4nal@mail.ru>

On Thu, Sep 10, 2026 at 11:53:51AM +0300, Vsevolod Myalitsin wrote:

Show 17 quoted lines

> @@ -98,16 +100,17 @@ static const char turn_off_instructions[] =
>  N_("\n"
>     "Disable this message with \"git config set advice.%s false\"");
>  
> -static void vadvise(const char *advice, int display_instructions,
> -		    const char *key, va_list params)
> +static void vadvise(const char *advice,
> +	const struct advice_setting *setting, va_list params)
>  {
>  	struct strbuf buf = STRBUF_INIT;
>  	const char *cp, *np;
>  
>  	strbuf_vaddf(&buf, advice, params);
>  
> -	if (display_instructions)
> -		strbuf_addf(&buf, turn_off_instructions, key);
> +	if (setting && setting->level == ADVICE_LEVEL_NONE) {

There is an opening brace at the end of this line ...

> +		strbuf_addf(&buf, turn_off_instructions,
> +					setting->key);

... but there is no corresponding closing brace here, leading to compilation errors.

Please make sure that each and every commit you submit can be built.

>  
>  	for (cp = buf.buf; *cp; cp = np) {
>  		np = strchrnul(cp, '\n');